[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210108173357.fhuvhnsg4hbdizkw@skbuf>
Date: Fri, 8 Jan 2021 19:33:57 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, alexandre.belloni@...tlin.com,
f.fainelli@...il.com, vivien.didelot@...il.com,
alexandru.marginean@....com, claudiu.manoil@....com,
xiaoliang.yang_1@....com, hongbo.wang@....com, kuba@...nel.org,
jiri@...nulli.us, idosch@...sch.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v2 net-next 03/10] net: dsa: add ops for devlink-sb
On Fri, Jan 08, 2021 at 12:35:23AM +0100, Andrew Lunn wrote:
> > +static struct dsa_port *devlink_to_dsa_port(struct devlink_port *dlp)
> > +{
> > + return container_of(dlp, struct dsa_port, devlink_port);
> > +}
>
> I wonder if this should be moved to include/net/dsa.h next to the
> other little helpers used to convert between devlink structures and
> DSA structures?
I wrote this before your series for devlink regions. The way I'm using
devlink_to_dsa_port, I guess I can just replace it with your
dsa_devlink_port_to_port function.
Powered by blists - more mailing lists