netdev - Re: [PATCH v3 net-next 03/10] net: dsa: add ops for devlink-sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/iiXIfDD9KdEGoI@lunn.ch>
Date:   Fri, 8 Jan 2021 19:20:12 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, alexandre.belloni@...tlin.com,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        alexandru.marginean@....com, claudiu.manoil@....com,
        xiaoliang.yang_1@....com, hongbo.wang@....com, kuba@...nel.org,
        jiri@...nulli.us, idosch@...sch.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net-next 03/10] net: dsa: add ops for devlink-sb

On Fri, Jan 08, 2021 at 07:59:43PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Switches that care about QoS might have hardware support for reserving
> buffer pools for individual ports or traffic classes, and configuring
> their sizes and thresholds. Through devlink-sb (shared buffers), this is
> all configurable, as well as their occupancy being viewable.
> 
> Add the plumbing in DSA for these operations.
> 
> Individual drivers still need to call devlink_sb_register() with the
> shared buffers they want to expose. A helper was not created in DSA for
> this purpose (unlike, say, dsa_devlink_params_register), since in my
> opinion it does not bring any benefit over plainly calling
> devlink_sb_register() directly.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew