netdev - Re: [PATCH v4 net-next 10/11] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24c6ef2f-36a6-8531-c7aa-d1a654f198af@gmail.com>
Date:   Fri, 8 Jan 2021 17:48:32 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vadym Kochan <vkochan@...vell.com>,
        Taras Chornyi <tchornyi@...vell.com>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Ivan Vecera <ivecera@...hat.com>,
        Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH v4 net-next 10/11] mlxsw: spectrum_switchdev: remove
 transactional logic for VLAN objects



On 1/8/2021 4:01 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning
> errors in commit phase"), the mlxsw driver performs the VLAN object
> offloading during the prepare phase. So conversion just seems to be a
> matter of removing the code that was running in the commit phase.
> 
> Ido Schimmel explains that the reason why mlxsw_sp_span_respin is called
> unconditionally is because the bridge driver will ignore -EOPNOTSUPP and
> actually add the VLAN on the bridge device - see commit 9c86ce2c1ae3
> ("net: bridge: Notify about bridge VLANs") and commit ea4721751977
> ("mlxsw: spectrum_switchdev: Ignore bridge VLAN events"). Since the VLAN
> was successfully added on the bridge device, mlxsw_sp_span_respin_work()
> should be able to resolve the egress port for a packet that is mirrored
> to a gre tap and passes through the bridge device. Therefore keep the
> logic as it is.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Acked-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian