netdev - Re: [PATCH] udp: Prevent reuseport_select_sock from reading uninitialized socks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210108191642.1963d3aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 Jan 2021 19:16:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Baptiste Lepers <baptiste.lepers@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] udp: Prevent reuseport_select_sock from reading
 uninitialized socks

On Thu, 7 Jan 2021 00:27:07 -0500 Willem de Bruijn wrote:
> On Thu, Jan 7, 2021 at 12:11 AM Baptiste Lepers
> <baptiste.lepers@...il.com> wrote:
> >
> > reuse->socks[] is modified concurrently by reuseport_add_sock. To
> > prevent reading values that have not been fully initialized, only read
> > the array up until the last known safe index instead of incorrectly
> > re-reading the last index of the array.
> >
> > Fixes: acdcecc61285f ("udp: correct reuseport selection with connected
> > sockets")
> > Signed-off-by: Baptiste Lepers <baptiste.lepers@...il.com>  
> 
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> 
> Thanks. This also matches local variable socks as used to calculate i
> and j with reciprocal_scale immediately above.
> 
> Please mark fixes [PATCH net] in the future.

And please don't wrap the fixes tags.

Applied, thanks!