netdev - Re: [PATCH net-next v4] GTP: add support for flow based tunneling API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210109192702.1b88a25a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 9 Jan 2021 19:27:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pravin B Shelar <pbshelar@...com>
Cc:     <netdev@...r.kernel.org>, <pablo@...filter.org>,
        <laforge@...monks.org>, <jonas@...rbonn.se>, <pravin.ovn@...il.com>
Subject: Re: [PATCH net-next v4] GTP: add support for flow based tunneling
 API

On Tue,  5 Jan 2021 20:45:05 -0800 Pravin B Shelar wrote:
> @@ -477,40 +572,99 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,
>  			     struct gtp_pktinfo *pktinfo)
>  {
>  	struct gtp_dev *gtp = netdev_priv(dev);
> +	struct gtpu_metadata *opts = NULL;
>  	struct pdp_ctx *pctx;
>  	struct rtable *rt;
>  	struct flowi4 fl4;
> -	struct iphdr *iph;
> -	__be16 df;
> +	struct sock *sk = NULL;
> +	__be32 tun_id;
> +	__be32 daddr;
> +	__be32 saddr;
> +	u8 gtp_version;
>  	int mtu;
> +	__u8 tos;
> +	__be16 df = 0;

Please hold rev xmas tree.

> @@ -706,6 +895,7 @@ static void gtp_dellink(struct net_device *dev, struct list_head *head)
>  			pdp_context_delete(pctx);
>  
>  	list_del_rcu(&gtp->list);
> +
>  	unregister_netdevice_queue(dev, head);
>  }
>  

Unrelated whitespace change.