netdev - Re: [PATCH net] netfilter: conntrack: fix reading nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210110083942.GA28800@salvia>
Date:   Sun, 10 Jan 2021 09:39:42 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netfilter-devel@...r.kernel.org, Florian Westphal <fw@...len.de>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] netfilter: conntrack: fix reading
 nf_conntrack_buckets

On Fri, Jan 08, 2021 at 12:44:33PM +0100, Jesper Dangaard Brouer wrote:
> The old way of changing the conntrack hashsize runtime was through changing
> the module param via file /sys/module/nf_conntrack/parameters/hashsize. This
> was extended to sysctl change in commit 3183ab8997a4 ("netfilter: conntrack:
> allow increasing bucket size via sysctl too").
> 
> The commit introduced second "user" variable nf_conntrack_htable_size_user
> which shadow actual variable nf_conntrack_htable_size. When hashsize is
> changed via module param this "user" variable isn't updated. This results in
> sysctl net/netfilter/nf_conntrack_buckets shows the wrong value when users
> update via the old way.
> 
> This patch fix the issue by always updating "user" variable when reading the
> proc file. This will take care of changes to the actual variable without
> sysctl need to be aware.

Applied, thanks.