netdev - Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ffb23fe-2764-b940-1154-db774e29abe0@ieee.org>
Date:   Mon, 11 Jan 2021 08:10:15 -0600
From:   Alex Elder <elder@...e.org>
To:     Jakub Kicinski <kuba@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        aleksander@...ksander.es, andrewlassalle@...omium.org,
        Alex Elder <elder@...nel.org>
Subject: Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV_DEV() for
 proper sysfs links

On 1/7/21 8:46 PM, Jakub Kicinski wrote:
> On Wed,  6 Jan 2021 11:07:55 +0100 Stephan Gerhold wrote:
>> At the moment it is quite hard to identify the network interface
>> provided by IPA in userspace components: The network interface is
>> created as virtual device, without any link to the IPA device.
>> The interface name ("rmnet_ipa%d") is the only indication that the
>> network interface belongs to IPA, but this is not very reliable.
>>
>> Add SET_NETDEV_DEV() to associate the network interface with the
>> IPA parent device. This allows userspace services like ModemManager
>> to properly identify that this network interface is provided by IPA
>> and belongs to the modem.
>>
>> Cc: Alex Elder <elder@...nel.org>
>> Fixes: a646d6ec9098 ("soc: qcom: ipa: modem and microcontroller")
>> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> 
> Alex, can we get an ack?

Too late, but this looks good.  Thank you for applying it.
I don't always spot messages not "To:" me.  I still need to
improve my mail filtering.  Sorry about that.

					-Alex