netdev - Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWObTT=wRyebs0BOX5Bx_5d_ox=uMdLnLLTnCkptY9Q8Q@mail.gmail.com>
Date:   Mon, 11 Jan 2021 10:34:15 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink

On Sun, Jan 10, 2021 at 9:29 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> bareudp_dellink() only needs the device list to hand it to
> unregister_netdevice_queue(). We can pass NULL in, and
> unregister_netdevice_queue() will do the unregistering.
> There is no chance for batching on the error path, anyway.
>
> Suggested-by: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>


Reviewed-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks for cleaning up!