netdev - Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 11:12:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, alexandre.belloni@...tlin.com,
        andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        alexandru.marginean@....com, claudiu.manoil@....com,
        xiaoliang.yang_1@....com, hongbo.wang@....com, jiri@...nulli.us,
        idosch@...sch.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct
 dsa_switch_ops

On Mon, 11 Jan 2021 19:01:58 +0200 Vladimir Oltean wrote:
> On Sat, Jan 09, 2021 at 05:24:19PM -0800, Jakub Kicinski wrote:
> > On Fri,  8 Jan 2021 19:59:44 +0200 Vladimir Oltean wrote:  
> > > From: Vladimir Oltean <vladimir.oltean@....com>
> > >
> > > The devlink function pointer names are super long, and they would break
> > > the alignment. So reindent the existing ops now by adding one tab.  
> >
> > Therefore it'd be tempting to prefix them with dl_ rather than full
> > devlink_  
> 
> Indentation is broken even with devlink_sb_occ_tc_port_bind_get reduced
> to dl_sb_occ_tc_port_bind_get.

Ack, still, shorter is better IMHO.