netdev - Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1250007e1e8b70c2ee5b0f3289c592f121ebaa8f.camel@perches.com>
Date:   Mon, 11 Jan 2021 11:20:33 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, corbet@....net,
        Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>
Subject: Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

On Mon, 2021-01-11 at 09:41 -0800, Jakub Kicinski wrote:
> On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:
> > On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:
> > > Drop Felix from Mediatek Ethernet driver maintainers.
> > > We haven't seen any tags since the initial submission.  
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS  
> > []
> > > @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
> > >  F:	drivers/dma/mediatek/
> > >  
> > > 
> > >  MEDIATEK ETHERNET DRIVER
> > > -M:	Felix Fietkau <nbd@....name>
> > >  M:	John Crispin <john@...ozen.org>
> > >  M:	Sean Wang <sean.wang@...iatek.com>
> > >  M:	Mark Lee <Mark-MC.Lee@...iatek.com>  
> > 
> > I think your script is broken as there are multiple subdirectories
> > for this entry and 

> 
> Quite the opposite, the script intentionally only counts contributions
> only to the code under the MAINTAINERS entry.

My mistake.  I'd seen Felix's name fairly often.

I ran this command:

$ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/
656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet

Saw that felix had worked on mediatek and then looked up files in
drivers/net with mediatek and conflated the wireless files and ethernet files.

btw: because I didn't see the script published and so can't verify what's
being done here, the MAINTAINERS file shows:

	F: *Files* and directories wildcard patterns.
	   A trailing slash includes all files and subdirectory files.
	   F:	drivers/net/	all files in and below drivers/net
	   F:	drivers/net/*	all files in drivers/net, but not below

cheers, Joe