netdev - Re: [PATCH 5/6] ethernet: stmmac: fix wrongly set buffer2 valid when sph unsupport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210111142425.1cec69ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 Jan 2021 14:24:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH 5/6] ethernet: stmmac: fix wrongly set buffer2 valid
 when sph unsupport

On Mon, 11 Jan 2021 19:35:37 +0800 Joakim Zhang wrote:
> In current driver, buffer2 available only when hardware supports split
> header. Wrongly set buffer2 valid in stmmac_rx_refill when refill buffer
> address. You can see that desc3 is 0x81000000 after initialization, but
> turn out to be 0x83000000 after refill.
> 
> Fixes: 67afd6d1cfdf ("net: stmmac: Add Split Header support and enable it in XGMAC cores")
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>

Please make sure there are no new sparse warnings (build flags: W=1 C=1):

drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:509:25: warning: invalid assignment: |=
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:509:25:    left side has type restricted __le32
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:509:25:    right side has type unsigned long
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:511:25: warning: invalid assignment: &=
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:511:25:    left side has type restricted __le32
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:511:25:    right side has type unsigned long