netdev - Re: [PATCH iproute2-next v2] rdma: Add support for the netlink extack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210111053038.GJ31158@unreal>
Date:   Mon, 11 Jan 2021 07:30:38 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Patrisious Haddad <phaddad@...dia.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        linux-netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH iproute2-next v2] rdma: Add support for the netlink extack

On Sun, Jan 10, 2021 at 10:23:06AM -0700, David Ahern wrote:
> On 1/2/21 11:17 PM, Leon Romanovsky wrote:
> > From: Patrisious Haddad <phaddad@...dia.com>
> >
> > Add support in rdma for extack errors to be received
> > in userspace when sent from kernel, so now netlink extack
> > error messages sent from kernel would be printed for the
> > user.
> >
> > Signed-off-by: Patrisious Haddad <phaddad@...dia.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> > David,
> >
> > Just as a note, rdmatool is heavily influenced by the devlink and
> > general code should probably be applicable for both tools. Most likely
> > that any core refactoring/fix in the devlink is needed for rdmatool too.
> >
>
> understood and it was not the best model to start with but here we are.
>
> Petr did a good job of refactoring when he added dcb, but rdma was
> slightly different so the refactoring did not update it.

I can work to reduce the gaps, just need to know them.

Thanks