netdev - RE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 09:46:00 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     YANG LI <abaci-bugfix@...ux.alibaba.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>
CC:     "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        Javed Hasan <jhasan@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison

Hi,
Thanks for a patch.

> -----Original Message-----
> From: YANG LI <abaci-bugfix@...ux.alibaba.com>
> Sent: Monday, January 11, 2021 2:59 PM
> To: jejb@...ux.ibm.com
> Cc: martin.petersen@...cle.com; Saurav Kashyap <skashyap@...vell.com>;
> Javed Hasan <jhasan@...vell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@...vell.com>; linux@...linux.org.uk; linux-
> scsi@...r.kernel.org; linux-kernel@...r.kernel.org; netdev@...r.kernel.org;
> YANG LI <abaci-bugfix@...ux.alibaba.com>
> Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
> 
> Signed-off-by: YANG LI <abaci-bugfix@...ux.alibaba.com>
> Reported-by: Abaci Robot<abaci@...ux.alibaba.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 46d185c..cec27f2 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int
> mode)
>  	else
>  		fc_fabric_logoff(qedf->lport);
> 
> -	if (qedf_wait_for_upload(qedf) == false)
> +	if (!qedf_wait_for_upload(qedf))
>  		QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
> 
>  #ifdef CONFIG_DEBUG_FS
> --
> 1.8.3.1

Acked-by: Saurav Kashyap <skashyap@...vell.com>