netdev - Re: [PATCH net v2] net: macb: Add default usrio config to default gem config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e611151-7fd4-bfb7-91ad-76245bf7cdb1@microchip.com>
Date:   Tue, 12 Jan 2021 09:02:06 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Atish Patra <atish.patra@....com>, <netdev@...r.kernel.org>
CC:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net v2] net: macb: Add default usrio config to default gem
 config

On 12/01/2021 at 02:47, Atish Patra wrote:
> There is no usrio config defined for default gem config leading to
> a kernel panic devices that don't define a data. This issue can be
> reproduced with microchip polar fire soc where compatible string
> is defined as "cdns,macb".
> 
> Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
> Signed-off-by: Atish Patra <atish.patra@....com>

Indeed.
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks! Best regards,
   Nicolas

> ---
> Changes from v1->v2:
> 1. Fixed that fixes tag.
> ---
>   drivers/net/ethernet/cadence/macb_main.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 814a5b10141d..47ee72ab7002 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = {
>          .dma_burst_length = 16,
>          .clk_init = macb_clk_init,
>          .init = macb_init,
> +       .usrio = &macb_default_usrio,
>          .jumbo_max_len = 10240,
>   };
> 
> --
> 2.25.1
> 


-- 
Nicolas Ferre