netdev - Re: [PATCH iproute2 v3 1/1] build: Fix link errors on some systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d36a9875-d15e-5170-86b3-70047439a8ea@nvidia.com>
Date:   Tue, 12 Jan 2021 12:33:04 +0200
From:   Roi Dayan <roid@...dia.com>
To:     Petr Machata <petrm@...dia.com>
CC:     <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        "Stephen Hemminger" <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 v3 1/1] build: Fix link errors on some systems



On 2021-01-11 6:51 PM, Petr Machata wrote:
> 
> Roi Dayan <roid@...dia.com> writes:
> 
>> diff --git a/lib/json_print_math.c b/lib/json_print_math.c
>> new file mode 100644
>> index 000000000000..3d560defcd3e
>> --- /dev/null
>> +++ b/lib/json_print_math.c
>> @@ -0,0 +1,46 @@
>> +/*
>> + * json_print_math.c		"print regular or json output, based on json_writer".
>> + *
>> + *             This program is free software; you can redistribute it and/or
>> + *             modify it under the terms of the GNU General Public License
>> + *             as published by the Free Software Foundation; either version
>> + *             2 of the License, or (at your option) any later version.
>> + *
> 
> This should have a SPDX tag instead of the license excerpt:
> 
> // SPDX-License-Identifier: GPL-2.0+
> 
>> + * Authors:    Julien Fortin, <julien@...ulusnetworks.com>
>> + */
> 
> sprint_size() comes from TC and predates iproute2 git repo (2004),
> whereas Cumulus Networks was around from 2010. So the authorship
> declaration is likely inaccurate. I think it's also unnecessary, and
> would just drop it.
> 
>> diff --git a/lib/utils_math.c b/lib/utils_math.c
>> new file mode 100644
>> index 000000000000..d67affeb16c2
>> --- /dev/null
>> +++ b/lib/utils_math.c
>> @@ -0,0 +1,133 @@
>> +/*
>> + * utils.c
>> + *
>> + *		This program is free software; you can redistribute it and/or
>> + *		modify it under the terms of the GNU General Public License
>> + *		as published by the Free Software Foundation; either version
>> + *		2 of the License, or (at your option) any later version.
>> + *
>> + * Authors:	Alexey Kuznetsov, <kuznet@....inr.ac.ru>
> 
> The same here re license and authorship. The latter might in fact be
> accurate in this case, but I would still drop it :)
> 
> Otherwise this looks good to me.
> 

great thanks. sending v4 with the updates.