netdev - Re: [PATCH net-next v2 1/7] ibmvnic: restore state in change-param reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jan 2021 10:35:47 -0800
From:   Dany Madden <drt@...ux.ibm.com>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, Lijun Pan <ljp@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>
Subject: Re: [PATCH net-next v2 1/7] ibmvnic: restore state in change-param
 reset

On 2021-01-12 10:14, Sukadev Bhattiprolu wrote:
> Restore adapter state before returning from change-param reset.
> In case of errors, caller will try a hard-reset anyway.
> 
> Fixes: 0cb4bc66ba5e ("ibmvnic: restore adapter state on failed reset")
> Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Reviewed-by: Dany Madden <drt@...ux.ibm.com>

> ---
>  drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
> b/drivers/net/ethernet/ibm/ibmvnic.c
> index f302504faa8a..d548779561fd 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1960,7 +1960,7 @@ static int do_change_param_reset(struct
> ibmvnic_adapter *adapter,
>  	if (rc) {
>  		netdev_err(adapter->netdev,
>  			   "Couldn't initialize crq. rc=%d\n", rc);
> -		return rc;
> +		goto out;
>  	}
> 
>  	rc = ibmvnic_reset_init(adapter, true);