netdev - Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63682fd5278a6b6bd116529b7b8a1487969edf80.camel@kernel.org>
Date:   Tue, 12 Jan 2021 12:06:47 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Eric Dumazet <edumazet@...gle.com>,
        George McCollister <george.mccollister@...il.com>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Arnd Bergmann <arnd@...db.de>, Taehee Yoo <ap420073@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, Florian Westphal <fw@...len.de>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Pravin B Shelar <pshelar@....org>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists_lock
 when retrieving device statistics

On Tue, 2021-01-12 at 15:44 +0200, Vladimir Oltean wrote:
> On Mon, Jan 11, 2021 at 03:46:32PM -0800, Saeed Mahameed wrote:
> > This can be very costly, holding a mutex while traversing the whole
> > netedv lists and reading their stats, we need to at least allow
> > multiple readers to enter as it was before, so maybe you want to
> > use
> > rw_semaphore instead of the mutex.
> > 
> > or just have a unified approach of rcu+refcnt/dev_hold as you did
> > for
> > bonding and failover patches #13..#14, I used the same approach to
> > achieve the same for sysfs and procfs more than 2 years ago, you
> > are
> > welcome to use my patches:
> > https://lore.kernel.org/netdev/4cc44e85-cb5e-502c-30f3-c6ea564fe9ac@gmail.com/
> 
> Ok, what mail address do you want me to keep for your sign off?

Either is fine. Just make sure author and signed-off are the same :).
Thanks!