netdev - Re: [PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7045438c-2f8b-b804-81bd-f9a5cf6e20bb@redhat.com>
Date:   Tue, 12 Jan 2021 11:17:02 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Cindy Lu <lulu@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        lingshan.zhu@...el.com
Subject: Re: [PATCH v1] vhost_vdpa: fix the problem in
 vhost_vdpa_set_config_call


On 2021/1/12 上午10:46, Cindy Lu wrote:
> in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa.


Should be "In"


> this cb.private will finally use in vhost_vdpa_config_cb as
> vhost_vdpa.Fix this issue


An whitespace is needed before Fix and a full stop after "issue"

Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa")

Acked-by: Jason Wang <jasowang@...hat.com>

Please post a V2 with the above fixed and cc stable.

Thanks


>
> Signed-off-by: Cindy Lu <lulu@...hat.com>
> ---
>   drivers/vhost/vdpa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index ef688c8c0e0e..3fbb9c1f49da 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -319,7 +319,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp)
>   	struct eventfd_ctx *ctx;
>   
>   	cb.callback = vhost_vdpa_config_cb;
> -	cb.private = v->vdpa;
> +	cb.private = v;
>   	if (copy_from_user(&fd, argp, sizeof(fd)))
>   		return  -EFAULT;
>