netdev - Re: [PATCH net] Revert "virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210113111337-mutt-send-email-mst@kernel.org>
Date:   Wed, 13 Jan 2021 11:14:14 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, Greg Thelen <gthelen@...gle.com>
Subject: Re: [PATCH net] Revert "virtio_net: replace
 netdev_alloc_skb_ip_align() with napi_alloc_skb()"

On Wed, Jan 13, 2021 at 04:53:38PM +0100, Eric Dumazet wrote:
> On Wed, Jan 13, 2021 at 4:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> 
> > To be clear, I now think the revert is not needed.
> >
> > I will post instead a patch that should take care of the problem both
> > for virtio and napi_get_frags() tiny skbs
> 
> Then later, we might change things so that the sk_buff cache being
> changed by Alexander Lobakin
> can also be used for these allocations.

That sounds like a great idea.

-- 
MST