netdev - Re: [PATCH net] rxrpc: Call state should be read with READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210113104134.40e9ebae@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 13 Jan 2021 10:41:34 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     netdev@...r.kernel.org,
        Baptiste Lepers <baptiste.lepers@...il.com>,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE()
 under some circumstances

On Wed, 13 Jan 2021 08:23:54 +0000 David Howells wrote:
> Jakub Kicinski <kuba@...nel.org> wrote:
> 
> > On Tue, 12 Jan 2021 15:59:15 +0000 David Howells wrote:  
> > > From: Baptiste Lepers <baptiste.lepers@...il.com>
> > > 
> > > The call state may be changed at any time by the data-ready routine in
> > > response to received packets, so if the call state is to be read and acted
> > > upon several times in a function, READ_ONCE() must be used unless the call
> > > state lock is held.
> > > 
> > > As it happens, we used READ_ONCE() to read the state a few lines above the
> > > unmarked read in rxrpc_input_data(), so use that value rather than
> > > re-reading it.
> > > 
> > > Signed-off-by: Baptiste Lepers <baptiste.lepers@...il.com>
> > > Signed-off-by: David Howells <dhowells@...hat.com>  
> > 
> > Fixes: a158bdd3247b ("rxrpc: Fix call timeouts")
> > 
> > maybe?  
> 
> Ah, yes.  I missed there wasn't a Fixes line.  Can you add that one in, or do
> I need to resubmit the patch?

Sure, added, just checking if you didn't leave it out on purpose.

Applied, thanks!