netdev - Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210112154326.00f45bf1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 12 Jan 2021 15:43:26 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Praveen Chaudhary <praveen5582@...il.com>
Cc:     davem@...emloft.net, corbet@....net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0 net-next 1/1] Allow user to set metric on default
 route learned via Router Advertisement.

On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote:
> Hi Jakub
> 
> Thanks for the review,
> 
> Sure, I will reraise the patch (again v0i, sonce no code changes) after adding space before '<'.
> 
> This patch adds lines in 'include/uapi/', that requires ABI version changes for debian build. I am not sure, if we need any such changes to avoid breaking allmodconfig. It will be really helpful, if you can look at the patch once 'https://lkml.org/lkml/2021/1/11/1668' and suggest on this. Thanks a lot again.

The code doesn't build, AFAIK it's because:

net/ipv6/ndisc.c:1322:8: error: too few arguments to function ‘rt6_add_dflt_router’