netdev - Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jan 2021 23:28:00 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal
 PHY

On 1/11/21 3:47 PM, Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
>> Unless the internal PHY is connected and started, the phylib will not
>> poll the PHY for state and produce state updates. Connect the PHY and
>> start/stop it.
> 
> Hi Marek
> 
> Please continue the conversion and remove all mii_calls.
> 
> ks8851_set_link_ksettings() calling mii_ethtool_set_link_ksettings()
> is not good, phylib will not know about changes which we made to the
> PHY etc.

Hi,

I noticed a couple of drivers implement both the mii and mdiobus 
options, I was pondering why is that. Is there some legacy backward 
compatibility reason for keeping both or is it safe to remove the mii 
support completely from the driver?

Either way, I will do that in a separate patch, so it could be reverted 
if it breaks something.