[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c7fb5e664bd4ef0751390deeb0cfec18093c2f6b.camel@wdc.com>
Date: Wed, 13 Jan 2021 02:35:16 +0000
From: Atish Patra <Atish.Patra@....com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
"claudiu.beznea@...rochip.com" <claudiu.beznea@...rochip.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH net v2] net: macb: Add default usrio config to default gem
config
On Tue, 2021-01-12 at 18:11 -0800, Jakub Kicinski wrote:
> On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote:
> > There is no usrio config defined for default gem config leading to
> > a kernel panic devices that don't define a data. This issue can be
> > reprdouced with microchip polar fire soc where compatible string
> > is defined as "cdns,macb".
> >
> > Fixes: edac63861db7 ("net: macb: Add default usrio config to
> > default gem config")
> > Signed-off-by: Atish Patra <atish.patra@....com>
> > ---
> > Changes from v1->v2:
> > 1. Fixed that fixes tag.
>
> Still needs a little bit of work:
>
> Fixes tag: Fixes: edac63861db7 ("net: macb: Add default usrio config
> to default gem config")
I am so sorry about this. I managed screw up my script to add Fixes tag
twice in a row :(.
> Has these problem(s):
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
>
> Please make sure to keep Nic's Ack when reposting.
Absolutely. Apologies again for the noise for this small fix.
--
Regards,
Atish
Powered by blists - more mailing lists