netdev - Re: [PATCH net] net: dsa: unbind all switches from tree when DSA master unbinds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210112185342.6d3c3116@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 12 Jan 2021 18:53:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH net] net: dsa: unbind all switches from tree when DSA
 master unbinds

On Tue, 12 Jan 2021 10:51:39 -0800 Florian Fainelli wrote:
> On 1/11/21 3:09 PM, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@....com>
> > 
> > Currently the following happens when a DSA master driver unbinds while
> > there are DSA switches attached to it:
> > 
> > $ echo 0000:00:00.5 > /sys/bus/pci/drivers/mscc_felix/unbind
> > ------------[ cut here ]------------
> > WARNING: CPU: 0 PID: 392 at net/core/dev.c:9507
> > Call trace:
> >  rollback_registered_many+0x5fc/0x688
> >  unregister_netdevice_queue+0x98/0x120
> >  dsa_slave_destroy+0x4c/0x88
> >  dsa_port_teardown.part.16+0x78/0xb0
> >  dsa_tree_teardown_switches+0x58/0xc0
> >  dsa_unregister_switch+0x104/0x1b8
> >  felix_pci_remove+0x24/0x48
> >  pci_device_remove+0x48/0xf0
> >  device_release_driver_internal+0x118/0x1e8
> >  device_driver_detach+0x28/0x38
> >  unbind_store+0xd0/0x100
> > [...]
> > 
> > Fixes: 2f1e8ea726e9 ("net: dsa: link interfaces with the DSA master to get rid of lockdep warnings")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>  
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Tested-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks!