[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r1mnhk6o.fsf@codeaurora.org>
Date: Thu, 14 Jan 2021 12:44:31 +0200
From: Kalle Valo <kvalo@...eaurora.org>
To: Petr Štetiar <ynezz@...e.cz>
Cc: Arnd Bergmann <arnd@...nel.org>, Felix Fietkau <nbd@....name>,
Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Ryder Lee <ryder.lee@...iatek.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Shayne Chen <shayne.chen@...iatek.com>,
Yiwei Chung <yiwei.chung@...iatek.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mt76: mt7915: fix misplaced #ifdef
Petr Štetiar <ynezz@...e.cz> writes:
> Arnd Bergmann <arnd@...nel.org> [2021-01-03 14:57:55]:
>
> Hi,
>
> just a small nitpick,
>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The lone '|' at the end of a line causes a build failure:
>>
>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error:
>> expected expression before '}' token
>>
>> Replace the #ifdef with an equivalent IS_ENABLED() check.
>>
>> Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob")
>
> I think, that the correct fixes tag is following:
>
> Fixes: 8aa2c6f4714e ("mt76: mt7915: support 32 station interfaces")
>
> I've used the af901eb4ab80 as well first in
> https://github.com/openwrt/mt76/pull/490 but then looked at it once more and
> actually found the probably correct 8aa2c6f4714e.
Ok, I'll change that during commit.
Felix, I'm planning to apply this to wireless-drivers and assigned this
to me in patchwork.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists