netdev - Re: [PATCH net-next v4 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e4b8672-fcbf-5abc-d988-907b9e8dcdc4@gmail.com>
Date:   Thu, 14 Jan 2021 10:37:55 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     George McCollister <george.mccollister@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Rob Herring <robh@...nel.org>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        "open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: dsa: add Arrow SpeedChips XRS700x
 driver

On 1/14/21 10:35 AM, George McCollister wrote:
>> Nothing frees up the successfully allocated p->mib_data[] in case of
>> errors so you would be leaking here.
> 
> In case of an error probe will end up returning an error and the
> memory will be free'd since it was allocated with a devm_ function,
> won't it?

Sorry completely missed that xrs700x_alloc_port_mib() used a
devm_kzalloc(), this is fine.
-- 
Florian