netdev - Re: [Patch net v3] cls_flower: call nla_ok() before nla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114133625.0d1ea5e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 Jan 2021 13:36:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, Cong Wang <cong.wang@...edance.com>,
        syzbot+2624e3778b18fc497c92@...kaller.appspotmail.com,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Xin Long <lucien.xin@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Patch net v3] cls_flower: call nla_ok() before nla_next()

On Thu, 14 Jan 2021 13:07:49 -0800 Cong Wang wrote:
> -			if (msk_depth)
> -				nla_opt_msk = nla_next(nla_opt_msk, &msk_depth);
>  			break;
>  		default:
>  			NL_SET_ERR_MSG(extack, "Unknown tunnel option type");
>  			return -EINVAL;
>  		}
> +
> +		if (!nla_opt_msk)
> +			continue;

Why the switch from !msk_depth to !nla_opt_msk?

Seems like previously providing masks for only subset of options 
would have worked.