lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jan 2021 16:07:39 -0700 From: Nathan Chancellor <natechancellor@...il.com> To: Andrii Nakryiko <andrii.nakryiko@...il.com> Cc: Masahiro Yamada <masahiroy@...nel.org>, Michal Marek <michal.lkml@...kovi.net>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, Sedat Dilek <sedat.dilek@...il.com> Subject: Re: [PATCH] bpf: Hoise pahole version checks into Kconfig On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote: > Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an > unrelated issue ([0]). If we can make this work, then it would catch > such issue early on, yet won't have any downsides of hiding > CONFIG_DEBUG_INFO_BTF if pahole is too old. WDYT? > > [0] https://lore.kernel.org/lkml/CAHk-=wh-+TMHPTFo1qs-MYyK7tZh-OQovA=pP3=e06aCVp6_kA@mail.gmail.com/ Yes, I think that would be exactly what we want because DEBUG_INFO_BTF could cause the build to error if PAHOLE_VERSION is not >= 116. I will try to keep an eye on that thread to see how it goes then respin this based on anything that comes from it. Cheers, Nathan
Powered by blists - more mailing lists