netdev - Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <268090ca-06dd-d7e2-c06b-b9282f3cbe67@denx.de>
Date:   Fri, 15 Jan 2021 13:45:45 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal
 PHY

On 1/14/21 2:54 PM, Andrew Lunn wrote:
> On Tue, Jan 12, 2021 at 11:28:00PM +0100, Marek Vasut wrote:
>> On 1/11/21 3:47 PM, Andrew Lunn wrote:
>>> On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
>>>> Unless the internal PHY is connected and started, the phylib will not
>>>> poll the PHY for state and produce state updates. Connect the PHY and
>>>> start/stop it.
>>>
>>> Hi Marek
>>>
>>> Please continue the conversion and remove all mii_calls.
>>>
>>> ks8851_set_link_ksettings() calling mii_ethtool_set_link_ksettings()
>>> is not good, phylib will not know about changes which we made to the
>>> PHY etc.
>>
>> Hi,
>>
>> I noticed a couple of drivers implement both the mii and mdiobus options.
> 
> Which ones?

boardcom b44.c and bcm63xx_enet.c for example

> Simply getting the link status might be safe, but if
> set_link_ksettings() or get_link_ksettings() is used, phylib is going
> to get confused when the PHY is changed without it knowing.. So please
> do remove all the mii calls as part of the patchset.

Isn't that gonna break some ABI ?

Also, is separate patch OK ?