lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jan 2021 16:00:19 +0100 From: Andrew Lunn <andrew@...n.ch> To: Marek Vasut <marex@...x.de> Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>, Lukas Wunner <lukas@...ner.de> Subject: Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: > When either the SPI or PAR variant is compiled as module AND the other > variant is compiled as built-in, the following build error occurs: > > arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': > ks8851_common.c:(.text+0x1564): undefined reference to `__this_module' > > Fix this by including the ks8851_common.c in both ks8851_spi.c and > ks8851_par.c. The DEBUG macro is defined in ks8851_common.c, so it > does not have to be defined again. DEBUG should not be defined for production code. So i would remove it altogether. There is kconfig'ury you can use to make them both the same. But i'm not particularly good with it. Andrew
Powered by blists - more mailing lists