netdev - Re: [PATCH net-next 0/6] net: ipa: GSI interrupt updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210114180837.793879ba@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 14 Jan 2021 18:08:37 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>, Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, evgreen@...omium.org,
        bjorn.andersson@...aro.org, cpratapa@...eaurora.org,
        subashab@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] net: ipa: GSI interrupt updates

On Thu, 14 Jan 2021 15:22:54 -0800 Saeed Mahameed wrote:
> On Wed, 2021-01-13 at 11:15 -0600, Alex Elder wrote:
> > This series implements some updates for the GSI interrupt code,
> > buliding on some bug fixes implemented last month.
> > 
> > The first two are simple changes made to improve readability and
> > consistency.  The third replaces all msleep() calls with comparable
> > usleep_range() calls.
> > 
> > The remainder make some more substantive changes to make the code
> > align with recommendations from Qualcomm.  The fourth implements a
> > much shorter timeout for completion GSI commands, and the fifth
> > implements a longer delay between retries of the STOP channel
> > command.  Finally, the last implements retries for stopping TX
> > channels (in addition to RX channels).
>
> A minor thing that bothers me about this series is that it looks like
> it is based on magic numbers and some redefined constant values
> according to some mysterious sources ;-) .. It would be nice to have
> some wording in the commit messages explaining reasoning and maybe
> "semi-official" sources behind the changes.
> 
> LGMT code style wise :) 
> 
> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>

Dropped the fixes tags (since its not a series of fixes) and applied.

Thanks!