netdev - Re: [PATCH net-next] net: dsa: set configure_vlan_while_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210115231458.ush3qo5lv6zk54qj@skbuf>
Date:   Sat, 16 Jan 2021 01:14:58 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Oleksij Rempel <linux@...pel-privat.de>
Subject: Re: [PATCH net-next] net: dsa: set
 configure_vlan_while_not_filtering to true by default

On Sat, Jan 16, 2021 at 01:12:48AM +0200, Vladimir Oltean wrote:
> On Fri, Jan 15, 2021 at 03:03:14PM -0800, Jakub Kicinski wrote:
> > On Thu, 14 Jan 2021 19:34:26 +0200 Vladimir Oltean wrote:
> > > From: Vladimir Oltean <vladimir.oltean@....com>
> > > 
> > > As explained in commit 54a0ed0df496 ("net: dsa: provide an option for
> > > drivers to always receive bridge VLANs"), DSA has historically been
> > > skipping VLAN switchdev operations when the bridge wasn't in
> > > vlan_filtering mode, but the reason why it was doing that has never been
> > > clear. So the configure_vlan_while_not_filtering option is there merely
> > > to preserve functionality for existing drivers. It isn't some behavior
> > > that drivers should opt into. Ideally, when all drivers leave this flag
> > > set, we can delete the dsa_port_skip_vlan_configuration() function.
> > 
> > No longer applies :(
> 
> What's the error?

Never mind, I know what happened. It rebased cleanly just because git is
smart. I'll resend a v2 with the updated context.