netdev - Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210116223510.gk56aylkpo35aoev@pali>
Date:   Sat, 16 Jan 2021 23:35:10 +0100
From:   Pali Rohár <pali@...nel.org>
To:     "Alejandro Colomar (man-pages)" <alx.manpages@...il.com>
Cc:     Michael Kerrisk <mtk.manpages@...il.com>,
        linux-man@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR
 SIOCSIFADDR SIOCDIFADDR

On Saturday 16 January 2021 01:41:24 Alejandro Colomar (man-pages) wrote:
> On 1/12/21 8:26 PM, Pali Rohár wrote:
> > On Sunday 10 January 2021 20:57:50 Alejandro Colomar (man-pages) wrote:
> >> [ CC += netdev ]
> >>
> >> On 1/10/21 5:38 PM, Pali Rohár wrote:
> >>> On Saturday 02 January 2021 19:39:52 Pali Rohár wrote:
> >>>> Also add description for struct in6_ifreq which is used for IPv6 addresses.
> >>>>
> >>>> SIOCSIFADDR and SIOCDIFADDR can be used to add or delete IPv6 address and
> >>>> pppd is using these ioctls for a long time. Surprisingly SIOCDIFADDR cannot
> >>>> be used for deleting IPv4 address but only for IPv6 addresses.
> >>>>
> >>>> Signed-off-by: Pali Rohár <pali@...nel.org>
> >>>> ---
> >>>>  man7/netdevice.7 | 50 +++++++++++++++++++++++++++++++++++++++++-------
> >>>>  1 file changed, 43 insertions(+), 7 deletions(-)
> >>>
> >>> Hello! Is something else needed for this patch?
> >>
> >> Hello Pali,
> >>
> >> Sorry, I forgot to comment a few more formatting/wording issues: see
> >> below.  Apart from that, I'd prefer Michael to review this one.
> >>
> >> Thanks,
> >>
> >> Alex
> > 
> > Hello Alex! I will try to explain configuring IPv4 and IPv6 addresses on
> > network interfaces, so you probably could have better way how to improve
> > description in "official" manpage. I'm not native English speaker, so I
> > would follow any suggestions from you.
> [...]
> 
> Hi Pali,
> 
> Thanks for explaining the process to me.
> However, I don't feel that I understand it enough to help you co-writing
> the text.  I lack much background to understand your explanation.  I'd
> help you with the language happily, if it was only that :)

OK! I will send a new patch version ...

> Maybe someone from netdev@ can help?  Or Michael?

... and other improvements can be done later.

> Regards,
> 
> Alex
> 
> 
> -- 
> Alejandro Colomar
> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
> http://www.alejandro-colomar.es/