lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Jan 2021 19:13:00 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Alexander Duyck <alexander.duyck@...il.com>, Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, "linux-sctp @ vger . kernel . org" <linux-sctp@...r.kernel.org>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Neil Horman <nhorman@...driver.com> Subject: Re: [PATCHv3 net-next 1/2] net: move the hsize check to the else block in skb_segment On Fri, 15 Jan 2021 17:39:02 -0800 Alexander Duyck wrote: > On Fri, Jan 15, 2021 at 1:36 AM Xin Long <lucien.xin@...il.com> wrote: > > > > After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), > > it goes to process frag_list when !hsize in skb_segment(). However, when > > using skb frag_list, sg normally should not be set. In this case, hsize > > will be set with len right before !hsize check, then it won't go to > > frag_list processing code. > > > > So the right thing to do is move the hsize check to the else block, so > > that it won't affect the !hsize check for frag_list processing. > > > > v1->v2: > > - change to do "hsize <= 0" check instead of "!hsize", and also move > > "hsize < 0" into else block, to save some cycles, as Alex suggested. > > > > Signed-off-by: Xin Long <lucien.xin@...il.com> > > Looks good to me. > > Reviewed-by: Alexander Duyck <alexanderduyck@...com> Applied, thanks!
Powered by blists - more mailing lists