netdev - Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YARW4DN9qxOZ7b25@nataraja>
Date:   Sun, 17 Jan 2021 16:25:20 +0100
From:   Harald Welte <laforge@...monks.org>
To:     Jonas Bonn <jonas@...rbonn.se>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Pravin B Shelar <pbshelar@...com>, netdev@...r.kernel.org,
        pablo@...filter.org
Subject: Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

Hi Jonas, Jakub and others,

On Sun, Jan 17, 2021 at 02:23:52PM +0100, Jonas Bonn wrote:
> This patch hasn't received any ACK's from either the maintainers or anyone
> else providing review.  The following issues remain unaddressed after
> review:

[...]

Full ACK from my point of view.  The patch is so massive that I
as the original co-author and co-maintainer of the GTP kernel module
have problems understanding what it is doing at all.  Furthermore,
I am actually wondering if there is any commonality between the existing
use cases and whatever the modified gtp.ko is trying to achieve.  Up to
the point on whether or not it makes sense to have both functionalities
in the same driver/module at all

> I'm not sure what the hurry is to get this patch into mainline.  Large and
> complicated patches like this take time to review; please revert this and
> allow that process to happen.

Also acknowledged and supported from my side.

-- 
- Harald Welte <laforge@...monks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)