netdev - RE: [EXTERNAL] Re: [PATCH v4 net-next 1/5] net: phy: Add PHY_RST_AFTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW4PR17MB4243814D9651CEF803B5BB0DDFA40@MW4PR17MB4243.namprd17.prod.outlook.com>
Date:   Mon, 18 Jan 2021 17:32:34 +0000
From:   "Badel, Laurent" <LaurentBadel@...on.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
        "fugang.duan@....com" <fugang.duan@....com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "richard.leitner@...data.com" <richard.leitner@...data.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "marex@...x.de" <marex@...x.de>
Subject: RE: [EXTERNAL]  Re: [PATCH v4 net-next 1/5] net: phy: Add
 PHY_RST_AFTER_PROBE flag



> 

-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 

-----------------------------

-----Original Message-----
> From: Florian Fainelli <f.fainelli@...il.com>
> Sent: Monday, January 18, 2021 6:03 PM
> To: Badel, Laurent <LaurentBadel@...on.com>; davem@...emloft.net;
> m.felsch@...gutronix.de; fugang.duan@....com; kuba@...nel.org;
> andrew@...n.ch; linux@...linux.org.uk; p.zabel@...gutronix.de;
> lgirdwood@...il.com; broonie@...nel.org; robh+dt@...nel.org;
> richard.leitner@...data.com; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; marex@...x.de
> Subject: [EXTERNAL] Re: [PATCH v4 net-next 1/5] net: phy: Add
> PHY_RST_AFTER_PROBE flag
> 
> 
> 
> On 1/18/2021 8:58 AM, Badel, Laurent wrote:
> > Add new flag PHY_RST_AFTER_PROBE for LAN8710/20/40. This flag is
> > intended for phy_probe() to assert hardware reset after probing the
> PHY.
> >
> > Signed-off-by: Laurent Badel <laurentbadel@...on.com>
> > ---
> >  drivers/net/phy/smsc.c | 4 ++--
> >  include/linux/phy.h    | 1 +
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index
> > ddb78fb4d6dc..5ee45c48efbb 100644
> > --- a/drivers/net/phy/smsc.c
> > +++ b/drivers/net/phy/smsc.c
> > @@ -433,7 +433,7 @@ static struct phy_driver smsc_phy_driver[] = {
> >  	.name		= "SMSC LAN8710/LAN8720",
> >
> >  	/* PHY_BASIC_FEATURES */
> > -
> > +	.flags		= PHY_RST_AFTER_PROBE,
> >  	.probe		= smsc_phy_probe,
> >  	.remove		= smsc_phy_remove,
> >
> > @@ -460,7 +460,7 @@ static struct phy_driver smsc_phy_driver[] = {
> >  	.name		= "SMSC LAN8740",
> >
> >  	/* PHY_BASIC_FEATURES */
> > -	.flags		= PHY_RST_AFTER_CLK_EN,
> > +	.flags		= PHY_RST_AFTER_CLK_EN & PHY_RST_AFTER_PROBE,
> 
> 
> Not PHY_RST_AFTER_CLK_EN | PHY_RST_AFTER_PROBE?
> --
> Florian

Ah, you are right, my mistake, so much for bisectability. I'll fix and re-send, sorry again.