netdev - Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKOOJTzGei6a0HUbs6wo5sHOwAAVzGLFmMzbJsR8QYpAwyYqfA@mail.gmail.com>
Date:   Mon, 18 Jan 2021 10:20:35 -0800
From:   Edwin Peer <edwin.peer@...adcom.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Michal Kubecek <mkubecek@...e.cz>,
        netdev <netdev@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Andrew Gospodarek <andrew.gospodarek@...adcom.com>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST

On Mon, Jan 18, 2021 at 9:49 AM David Ahern <dsahern@...il.com> wrote:

> Different bug, different solution required. The networking stack hits
> these kind of scalability problems from time to time with original
> uapis, so workarounds are needed. One example is rtmsg which only allows
> 255 routing tables, so RTA_TABLE attribute was added as a u32. Once a
> solution is found for the VF problem, iproute2 can be enhanced to
> accommodate.

The problem is even worse, because user space already depends on the
broken behavior. Erroring out will cause the whole ip link show
command to fail, which works today. Even though the VF list is bust,
the rest of the netdevs are still dumped correctly. A hard fail would
break those too.

Regards,
Edwin Peer

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4160 bytes)