lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210118111021.6e423363@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 18 Jan 2021 11:10:21 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     Bhaskar Upadhaya <bupadhaya@...vell.com>, <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>
Subject: Re: [EXT] Re: [PATCH net-next 1/3] qede: add netpoll support for
 qede driver

On Sun, 17 Jan 2021 17:35:30 +0100 Igor Russkikh wrote:
> > On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote:  
> >> Add net poll controller support to transmit kernel printks
> >> over UDP  
> > 
> > Why do you need this patch? Couple years back netpoll was taught 
> > how to pull NAPIs by itself, and all you do is schedule NAPIs.
> > 
> > All the driver should do is to make sure that when napi is called 
> > with budget of 0 it only processes Tx completions, not Rx traffic.  
> 
> Hi Jakub,
> 
> Thanks for the hint, we were not aware of that.
> 
> I see our driver may not handle zero budget accordingly. Will check.
> 
> But then, all this means .ndo_poll_controller is basically deprecated?

It's still needed for special devices, off the top of my head for
example bonding uses it to poll its members. But for normal NIC
drivers, yes, it's pretty much deprecated.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ