netdev - RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB3844F07254AB8B1164086D7FDFA40@OSAPR01MB3844.jpnprd01.prod.outlook.com>
Date:   Mon, 18 Jan 2021 10:17:04 +0000
From:   "ashiduka@...itsu.com" <ashiduka@...itsu.com>
To:     'Andrew Lunn' <andrew@...n.ch>
CC:     "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "torii.ken1@...itsu.com" <torii.ken1@...itsu.com>
Subject: RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

Hi Andrew

> > Do you know how to switch between master/slave?
> 
> There was a patch to ethtool merged for this:
> 
> commit 558f7cc33daf82f945af432c79db40edcbe0dad0
> Author: Oleksij Rempel <o.rempel@...gutronix.de>
> Date:   Wed Jun 10 10:37:43 2020 +0200
> 
>     netlink: add master/slave configuration support

I know this.
--
# ./ethtool --version
ethtool version 5.10
# ./ethtool -s eth1 master-slave slave-force 
ethtool (-s): invalid value 'slave-force' for parameter 'master-slave'
--

As I wrote in the previous e-mail, it doesn't work because it doesn't 
include the process to parse the master-slave argument.

> The help of the ethtool command can show about the "master-slave" 
> option, but it doesn't seem to handle the arguments.
> I checked ethtool.c and it seems that do_sset () doesn't implement the 
> process of parsing master-slave arguments...

Once ethtool works properly, I will test the master-slave switching behavior.