netdev - Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fb95388-9564-7555-06c0-3126f95c34b3@nvidia.com>
Date:   Mon, 18 Jan 2021 23:53:18 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     Tobias Waldekranz <tobias@...dekranz.com>, <davem@...emloft.net>,
        <kuba@...nel.org>, <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <roopa@...dia.com>,
        <netdev@...r.kernel.org>, <jiri@...nulli.us>, <idosch@...sch.org>,
        <stephen@...workplumber.org>
Subject: Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in
 FDB notifications

On 18/01/2021 23:50, Vladimir Oltean wrote:
> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote:
>> Apologies for the multiple emails, but wanted to leave an example:
>>
>> 00:11:22:33:44:55 dev ens16 master bridge permanent
>>
>> This must always exist and user-space must be able to create it, which
>> might be against what you want to achieve (no BR_FDB_LOCAL entries with
>> fdb->dst != NULL).
> 
> Can you give me an example of why it would matter that fdb->dst in this
> case is set to ens16?
> 

Can you dump it as "dev ens16" without it? :) 
Or alternatively can you send a notification with "dev ens16" without it?

I'm in favor of removing it, but it is risky since some script somewhere might
be searching for it, or some user-space daemon might expect to see a notification
for such entries and react on it.