netdev - Re: [PATCH bpf-next] samples/bpf: add BPF_ATOMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d7d272f-5b7f-0e0b-8429-bb368ce57d1e@intel.com>
Date:   Mon, 18 Jan 2021 12:00:13 +0100
From:   Björn Töpel <bjorn.topel@...el.com>
To:     Brendan Jackman <jackmanb@...gle.com>,
        Björn Töpel <bjorn.topel@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        bpf <bpf@...r.kernel.org>, magnus.karlsson@...el.com
Subject: Re: [PATCH bpf-next] samples/bpf: add BPF_ATOMIC_OP macro for BPF
 samples

On 2021-01-18 11:57, Brendan Jackman wrote:
> I actually deliberately skipped this file, thinking that people were
> unlikely to want to add assembly-based atomics code under samples/
> 
> I guess it's nice for people to be able to e.g. move/copy code from
> the selftests.
>

Yes, that, and the fact that one sample broke w/o the BPF_ATOMIC_OP.


> On Mon, 18 Jan 2021 at 10:18, Björn Töpel <bjorn.topel@...il.com> wrote:
>>
>> From: Björn Töpel <bjorn.topel@...el.com>
>>
>> Brendan Jackman added extend atomic operations to the BPF instruction
>> set in commit 7064a7341a0d ("Merge branch 'Atomics for eBPF'"), which
>> introduces the BPF_ATOMIC_OP macro. However, that macro was missing
>> for the BPF samples. Fix that by adding it into bpf_insn.h.
>>
>> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
> 
> Reviewed-by: Brendan Jackman <jackmanb@...gle.com>
>

Thanks!
Björn