netdev - Re: [PATCH net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2fc48f6-aa2f-081a-dbce-312b869b8e04@huawei.com>
Date:   Mon, 18 Jan 2021 19:20:23 +0800
From:   Huazhong Tan <tanhuazhong@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <huangdaode@...wei.com>, <linuxarm@...neuler.org>,
        Guangbin Huang <huangguangbin2@...wei.com>
Subject: Re: [PATCH net-next] net: hns3: debugfs add dump tm info of nodes,
 priority and qset


On 2021/1/17 10:23, Jakub Kicinski wrote:
> On Fri, 15 Jan 2021 15:09:29 +0800 Huazhong Tan wrote:
>> From: Guangbin Huang <huangguangbin2@...wei.com>
>>
>> To increase methods to dump more tm info, adds three debugfs commands
>> to dump tm info of nodes, priority and qset. And a new tm file of debugfs
>> is created for only dumping tm info.
>>
>> Unlike previous debugfs commands, to dump each tm information, user needs
>> to enter two commands now. The first command writes parameters to tm and
>> the second command reads info from tm. For examples, to dump tm info of
>> priority 0, user needs to enter follow two commands:
>> 1. echo dump priority 0 > tm
>> 2. cat tm
>>
>> The reason for adding new tm file is because we accepted Jakub Kicinski's
>> opinion as link https://lkml.org/lkml/2020/9/29/2101. And in order to
>> avoid generating too many files, we implement write ops to allow user to
>> input parameters.
> Why are you trying to avoid generating too many files? How many files
> would it be? What's the size of each dump/file?


The maximum number of tm node, priority and qset are 8, 256,
1280, if we create a file for each one, then there are 8 node
files, 256 priority files, 1280 qset files. It seems a little
bit hard for using as well.


Thanks.

>> However, If there are two or more users concurrently write parameters to
>> tm, parameters of the latest command will overwrite previous commands,
>> this concurrency problem will confuse users, but now there is no good
>> method to fix it.
> .