netdev - Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210119111419.20be1cf0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 19 Jan 2021 11:14:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        wangyunjian <wangyunjian@...wei.com>, jasowang@...hat.com,
        willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        jerry.lilijun@...wei.com, chenchanghu@...wei.com,
        xudingke@...wei.com, brian.huangbin@...wei.com
Subject: Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when
 sendmsg fails

On Tue, 19 Jan 2021 04:56:59 -0500 Michael S. Tsirkin wrote:
> On Mon, Jan 18, 2021 at 02:33:29PM -0800, Jakub Kicinski wrote:
> > On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote:  
> > > From: Yunjian Wang <wangyunjian@...wei.com>
> > > 
> > > Currently the driver doesn't drop a packet which can't be sent by tun
> > > (e.g bad packet). In this case, the driver will always process the
> > > same packet lead to the tx queue stuck.
> > > 
> > > To fix this issue:
> > > 1. in the case of persistent failure (e.g bad packet), the driver
> > >    can skip this descriptor by ignoring the error.
> > > 2. in the case of transient failure (e.g -ENOBUFS, -EAGAIN and -ENOMEM),
> > >    the driver schedules the worker to try again.
> > > 
> > > Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>  
> > 
> > Michael, LMK if you want to have a closer look otherwise I'll apply
> > tomorrow.  
> 
> Thanks for the reminder. Acked.

Applied, thanks everyone!