netdev - Re: [PATCH v2 net-next ] net/sched: cls_flower add CT_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210119200323.GA3961@horizon.localdomain>
Date:   Tue, 19 Jan 2021 17:03:23 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     wenxu@...oud.cn
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next ] net/sched: cls_flower add CT_FLAGS_INVALID
 flag support

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

The patch looks good to me, just some side comments below.

On Tue, Jan 19, 2021 at 04:31:50PM +0800, wenxu@...oud.cn wrote:
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3878,6 +3878,7 @@ int dev_loopback_xmit(struct net *net, struct sock *sk, struct sk_buff *skb)

I don't know why, but your patches often have function names here that
are not accurate. 

>  
>  	/* qdisc_skb_cb(skb)->pkt_len was already set by the caller. */
>  	qdisc_skb_cb(skb)->mru = 0;
> +	qdisc_skb_cb(skb)->post_ct = false;
>  	mini_qdisc_bstats_cpu_update(miniq, skb);
>  
>  	switch (tcf_classify(skb, miniq->filter_list, &cl_res, false)) {
> @@ -4960,6 +4961,7 @@ static __latent_entropy void net_tx_action(struct softirq_action *h)

Here as well.

>  
>  	qdisc_skb_cb(skb)->pkt_len = skb->len;
>  	qdisc_skb_cb(skb)->mru = 0;
> +	qdisc_skb_cb(skb)->post_ct = false;
>  	skb->tc_at_ingress = 1;
>  	mini_qdisc_bstats_cpu_update(miniq, skb);
>  
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 2d70ded..c565c7a 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -237,9 +237,8 @@ void skb_flow_dissect_meta(const struct sk_buff *skb,

Here, I would expect to see a label/function name just before the
skb_flow_dissect_ct definition. But that's
skb_flow_dissect_set_enc_addr_type. skb_flow_dissect_meta is still one
other function up.

>  void
>  skb_flow_dissect_ct(const struct sk_buff *skb,
>  		    struct flow_dissector *flow_dissector,
> -		    void *target_container,
> -		    u16 *ctinfo_map,
> -		    size_t mapsize)
> +		    void *target_container, u16 *ctinfo_map,
> +		    size_t mapsize, bool post_ct)
>  {
>  #if IS_ENABLED(CONFIG_NF_CONNTRACK)
>  	struct flow_dissector_key_ct *key;