[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d75b2c43a416d4bb84185aab4005d42e49962e36.camel@sipsolutions.net>
Date: Tue, 19 Jan 2021 09:53:29 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Eric Dumazet <edumazet@...gle.com>,
Ben Greear <greearb@...delatech.com>,
Rainer Suhm <automat@...teo.de>
Cc: Jakub Kicinski <kuba@...nel.org>,
Luca Coelho <luciano.coelho@...el.com>,
netdev <netdev@...r.kernel.org>, linux-wireless@...r.kernel.org,
Willem de Bruijn <willemb@...gle.com>
Subject: Re: net: tso: add UDP segmentation support: adds regression for
ax200 upload
Hi Eric, all,
Sorry we've been so silent on this.
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> @@ -773,6 +773,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,
> unsigned int num_subframes,
>
> next = skb_gso_segment(skb, netdev_flags);
> skb_shinfo(skb)->gso_size = mss;
> + skb_shinfo(skb)->gso_type = ipv4 ? SKB_GSO_TCPV4 : SKB_GSO_TCPV6;
> if (WARN_ON_ONCE(IS_ERR(next)))
> return -EINVAL;
> else if (next)
> @@ -795,6 +796,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,
> unsigned int num_subframes,
>
> if (tcp_payload_len > mss) {
> skb_shinfo(tmp)->gso_size = mss;
> + skb_shinfo(tmp)->gso_type = ipv4 ?
> SKB_GSO_TCPV4 : SKB_GSO_TCPV6;
> } else {
> if (qos) {
> u8 *qc;
This does fix the problems reported on iwlwifi, were you planning to
submit it as a proper patch?
Thanks,
johannes
Powered by blists - more mailing lists