netdev - Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 20 Jan 2021 05:56:18 +0100
From:   Giacinto Cifelli <gciofono@...il.com>
To:     Reinhard Speyerer <rspmn@...nline.de>
Cc:     netdev@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>, rspmn@...or.de
Subject: Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion
 PLSx3 modem family

Hi Reinhard,

>
> AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> examples from other UE vendors.
>
thank you for these suggestions.  Indeed I have removed that line,
retested, and the interface works properly.
I am submitting a v2 patch.

Regards,
Giacinto