netdev - Re: [PATCH] net: systemport: free dev before on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c291aebe-4cb4-9fe7-0635-5b518d92c311@gmail.com>
Date:   Tue, 19 Jan 2021 21:07:10 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Pan Bian <bianpan2016@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: systemport: free dev before on error path



On 1/19/2021 8:44 PM, Pan Bian wrote:
> On the error path, it should goto the error handling label to free
> allocated memory rather than directly return.
> 
> Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock")
> Signed-off-by: Pan Bian <bianpan2016@....com>

The change is correct, but not the Fixes tag, it should be:

Fixes: 31bc72d97656 ("net: systemport: fetch and use clock resources")

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian