netdev - Re: [PATCH net] selftests/net: set link down before enslave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120104210.GA2602142@shredder.lan>
Date:   Wed, 20 Jan 2021 12:42:10 +0200
From:   Ido Schimmel <idosch@...dia.com>
To:     Hangbin Liu <liuhangbin@...il.com>
CC:     <netdev@...r.kernel.org>, Jiri Pirko <jiri@...dia.com>,
        "Nikolay Aleksandrov" <nikolay@...dia.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] selftests/net: set link down before enslave

On Wed, Jan 20, 2021 at 06:29:47PM +0800, Hangbin Liu wrote:
> Set the link down before enslave it to a bond device, to avoid
> Error: Device can not be enslaved while up.
> 
> Fixes: 6374a5606990 ("selftests: rtnetlink: Test bridge enslavement with different parent IDs")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index c9ce3dfa42ee..a26fddc63992 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -1205,6 +1205,8 @@ kci_test_bridge_parent_id()
>  	dev20=`ls ${sysfsnet}20/net/`
>  
>  	ip link add name test-bond0 type bond mode 802.3ad
> +	ip link set dev $dev10 down
> +	ip link set dev $dev20 down

But these netdevs are created with their administrative state set to
'DOWN'. Who is setting them to up?

>  	ip link set dev $dev10 master test-bond0
>  	ip link set dev $dev20 master test-bond0
>  	ip link add name test-br0 type bridge
> -- 
> 2.26.2
>