netdev - tcp: rearm RTO timer does not comply with RFC6298

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1611139794-11254-1-git-send-email-yangpc@wangsu.com>
Date:   Wed, 20 Jan 2021 18:49:54 +0800
From:   Pengcheng Yang <yangpc@...gsu.com>
To:     ncardwell@...gle.com, ycheng@...gle.com
Cc:     netdev@...r.kernel.org, yangpc@...gsu.com
Subject: tcp: rearm RTO timer does not comply with RFC6298

hi,

I have a doubt about tcp_rearm_rto().

Early TCP always rearm the RTO timer to NOW+RTO when it receives
an ACK that acknowledges new data.

Referring to RFC6298 SECTION 5.3: "When an ACK is received that
acknowledges new data, restart the retransmission timer so that
it will expire after RTO seconds (for the current value of RTO)."

After ER and TLP, we rearm the RTO timer to *tstamp_of_head+RTO*
when switching from ER/TLP/RACK to original RTO in tcp_rearm_rto(),
in this case the RTO timer is triggered earlier than described in 
RFC6298, otherwise the same.

Is this planned? Or can we always rearm the RTO timer to 
tstamp_of_head+RTO?

Thanks.