netdev - Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jan 2021 15:37:59 +0100
From:   Giacinto Cifelli <gciofono@...il.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Reinhard Speyerer <rspmn@...nline.de>, netdev@...r.kernel.org,
        rspmn@...or.de
Subject: Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion
 PLSx3 modem family

Hi Bjørn,


On Wed, Jan 20, 2021 at 2:13 PM Bjørn Mork <bjorn@...k.no> wrote:
>
> Giacinto Cifelli <gciofono@...il.com> writes:
>
> > Hi Bjørn,
> > I have fixed and resent, but from your comment I might not have
> > selected the right line from maintaner.pl?
> > what I have is this:
> > $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
> > "Bjørn Mork" <bjorn@...k.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
> > "David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
> > Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
> > netdev@...r.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
> > <<<< this seems the right one
> > linux-usb@...r.kernel.org (open list:USB NETWORKING DRIVERS)
> > linux-kernel@...r.kernel.org (open list)
> >
> > I have at the same time sent a patch for another enumeration of the
> > same product, for cdc_ether.  In that case, I have picked the
> > following line, which also looked the best fit:
> >   linux-usb@...r.kernel.org (open list:USB CDC ETHERNET DRIVER)
> >
> > Did I misinterpret the results of the script?
>
> Yes, but I'll be the first to admit that it isn't easy.
>
> netdev is definitely correct, and the most important one.
>
> But in theory you are supposed to use all the listed addresses.  Except
> that I don't think you need to CC David (and Jakub?) since they probably
> read everything in netdev anyway.  And I believe many (most?) people
> leave out the linux-kernel catch-all, since it doesn't provide any extra
> coverage for networking. At least I do.
>
> Then there's the two remaining addresses.  The linux-usb list is
> traditionally CCed on patches touching USB drivers, since the USB
> experts are there and not necessarily in netdev.  And I'd like a copy
> because that's the only way I'll be able to catch these patches.  I
> don't read any of the lists regularily.
>
> This is my interpretation only.  I am sure there are other opinions. But
> as usual, you cannot do anything wrong. The worst that can ever happen
> is that you have to resend a patch or miss my review of it ;-)
>

looks like "welcome to the maze" :D

So, the letter of the instructions would be send all, but up to you to
leave some of them out.
Got it.
I am going to wait a couple of days on the off chance that my patches
are reviewed, then I will resend.

Thank you and regards,
Giacinto